Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Substitute for #124 #125

Merged
merged 1 commit into from
Oct 10, 2012
Merged

Conversation

DennisKehrig
Copy link
Contributor

Modified fix for adobe/brackets#1147 (and probably adobe/brackets#1689) based on Glenn's work in #120.

Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.

Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets.
Subsequent launches use stored window size and position which is adjusted automatically by the OS.
@jasonsanjose
Copy link
Member

Reviewing

@jasonsanjose
Copy link
Member

I wasn't able to reproduce adobe/brackets#1147 in the current master branch with Glenn's changes on my macbook air at 800x600. Is there another trick to get it to reproduce without commenting those lines out and recompiling?

@jasonsanjose
Copy link
Member

Looks good. Just wanted to confirm the existing bug with @DennisKehrig.

@DennisKehrig
Copy link
Contributor Author

You can try deleting /Users/<username>/Library/Preferences/io.brackets.appshell.plist
I also deleted io.brackets.appshell.plist.90T0uZH and io.brackets.appshell.plist.lockfile in the same directory, not sure that makes a difference.
I could reproduce the bug this way with daily build 2012-10-10_02-00-18.

@jasonsanjose
Copy link
Member

Thanks @DennisKehrig. I was able to confirm the bug in the existing build at 800x600 and I also confirmed your fix. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants